search

webdriverio-boneyard / wdio-devtools-service

WebdriverIO v4 service that enables DevTools functionality for you WebDriver session
http://webdriver.io
MIT License
26 stars 11 forks source link

Update to work with chromedriver >= 2.39, build script fix for Windows #11

Closed Eduard-iCH closed 6 years ago

Eduard-iCH commented 6 years ago

Tested both on macOS and Windows 7.

By the way - chrome://vesrion is empty in headless mode. So still need to find a better way.

Eduard-iCH commented 6 years ago

Yes, i can port it in 0-2 days. Need to install v5.

christian-bromann commented 6 years ago

Yes, i can port it in 0-2 days. Need to install v5.

There is a Contribution.md that should help you getting started, if you have any issues, let us know in the v5 gitter channel. Thanks!

christian-bromann commented 6 years ago

@Eduard-iCH I ported the change to v5. You only need to sign the CLA to get this merged. Thanks!

mauricioardiles-ml commented 6 years ago

Hi, is there any change to get this fix for Mac and Linux ?

christian-bromann commented 6 years ago

@Eduard-iCH would you mind signing the CLA so I can merge this?

mansn commented 6 years ago

Isn't this PR pretty much the same thing that was done in this commit: https://github.com/webdriverio-boneyard/wdio-devtools-service/commit/f89f75009c7a39fafe3b4b0c7079d456e24df73e ?

christian-bromann commented 6 years ago

Isn't this PR pretty much the same thing that was done in this commit: f89f750 ?

Yes, closing.