webdriverio-boneyard / wdio-jasmine-framework

A WebdriverIO v4 plugin. Adapter for Jasmine testing framework.
http://webdriver.io/
MIT License
23 stars 23 forks source link

Session not ended after exceptions thrown #12

Closed patthiel closed 8 years ago

patthiel commented 8 years ago

The problem

When a waitFor command or waitUntil times out, it throws an exception like below.. However, after this error is encountered, the runner fails to end the session where the error was encountered. Leaving many dead browsers open, when running a full suite of integration tests.

/Developer/myProject/node_modules/wdio-jasmine-framework/node_modules/wdio-sync/node_modules/fibers/future.js:313
                        throw(ex);
                        ^
Error: element (something) still not existing after 5000ms

Environment

Selenium Logs Wdio Logs

Code To Reproduce Issue

Example Spec

@christian-bromann i don't think this is happening with each framework, so i'm posting it here as a jasmine specific bug. Let me know if you think this is more a wdio bug and i can close this and open it in that project

mattc41190 commented 8 years ago

+1

Also happens to me. I have not looked into whether or not the same issue occurs in Mocha or Cucumber implementations.

lrobanthro commented 8 years ago

+1 waitUntil is one of those vital commands that allows testers to avoided the dreaded browser.pause!

christian-bromann commented 8 years ago

I will look at it asap

christian-bromann commented 8 years ago

@patthiel could you retry with the recent published version?

patthiel commented 8 years ago

This works as expected now! 🎉