Closed Kignuf closed 7 years ago
Tests also fail locally with a clean clone of the repo. This is due to some linting errors that seem to have been made on purpose. I've run manually the non linting tests and they are all green.
Hello Christian, I just pushed a test, please let me know if that's fine for you.
I appologize for those mistakes. I've amended the last commit to remove the trailing spaces and the console.log.
Thanks a lot for your review Christian !
@Kignuf last thing: could you please update your branch via rebase?
$ git checkout master
$ git pull origin master
$ git checkout fixUndefinedTestTitle
$ git rebase master
$ git push origin fixUndefinedTestTitle
Thanks
@christian-bromann It should be ok now
\o/ thanks Christian, that's awesome !
Fixes a crash when using cucumber hooks (https://github.com/webdriverio/wdio-junit-reporter/issues/65)
Cucumber hooks will add an "undefined" test in suite.tests See following example:
This PR fixes the crash by verifying that the test is not undefined before doing anything with it.