search

webdriverio-boneyard / wdio-junit-reporter

A WebdriverIO v4 plugin. Report results in junit xml format.
http://v4.webdriver.io
MIT License
11 stars 42 forks source link

Suite/test are always lowercase in test reports #80

Closed patthiel closed 6 years ago

patthiel commented 6 years ago

When we upgraded from 0.2.0 to 0.3.1 we noticed in our test reports that the test names went from "should Test this Thing in Here" to all lower case "should test this thing in here".

We find this an issue because we use capital letters to facilitate formatting some of our test names (perhaps this is non-standard, but it's the way we've chosen to do it).

I have a patch that could be applied to fix that removes the toLowerCase being called on suites/tests and would have to modify the default suite name regex.

I'll push up a PR with a unit test shortly if there is no opposition to this. cc @christian-bromann

mcelotti commented 6 years ago

Hi patthiel, if @christian-bromann has no objection I can make the PR for the current version (0.4.0)

christian-bromann commented 6 years ago

I have not strong opinion on this, so if you guys find it annoying, feel free to shoot a PR

mcelotti commented 6 years ago

Ok, since there's no special reason for being lowercase I'll create the PR

ianrenauld commented 6 years ago

Something went wrong with this PR, as all uppercase letters are now disappearing (at least for me). See #91

patthiel commented 6 years ago

Sorry guys, somehow i missed this communication. @mcelotti thanks for PR'ing!

christian-bromann commented 6 years ago

I will close this then!