(WIP) Upgrade wdio-sync to support node@12

webdriverio-boneyard / wdio-mocha-framework

A WebdriverIO v4 plugin. Adapter for Mocha testing framework.

MIT License

39 stars 30 forks source link

Open renfeng opened 5 years ago

renfeng commented 5 years ago

fiber@4, a dependency of wdio-sync, is required. See https://github.com/laverdet/node-fibers/issues/409

jsf-clabot commented 5 years ago

All committers have signed the CLA.

pathmapper commented 5 years ago

renfeng commented 5 years ago

this package version doesn't exist

Sorry that I didn't test it properly before making the pull request. Will push more chance. Hold on.

renfeng commented 5 years ago

Now the unit tests fail with TypeError: _get__(...) is not a function

renfeng commented 5 years ago

Downgraded @wdio/sync to 5.8.0 the first version introduced fibers@4. Hope that would bring the gap between wdio-sync@0.7.3 a little closer...

Can you take a look and fix the failing unit tests? Thanks.

christian-bromann commented 5 years ago

@renfeng @wdio/sync is for v5 and not v4 (where we use wdio-sync)

renfeng commented 5 years ago

@renfeng @wdio/sync is for v5 and not v4 (where we use wdio-sync)

Thanks for pointing it out! Then we'll have to wait for the next release version of wdio-sync. See their fix, https://github.com/webdriverio-boneyard/wdio-sync/pull/136

christian-bromann commented 5 years ago

Thanks for pointing it out! Then we'll have to wait for the next release version of wdio-sync.

I would recommend to upgrade to WebdriverIO v5

pathmapper commented 5 years ago

I would recommend to upgrade to WebdriverIO v5

@christian-bromann so v4 is not maintained anymore and there will be no new releases? I did not find any information on this matter.

christian-bromann commented 5 years ago

there will be no new releases?

There will, but people haven't had the chance to make that release. Anyway I urgently recommend to move to v5.