search

webdriverio-boneyard / wdio-sauce-service

WebdriverIO v4 service for better Sauce Labs integration
http://webdriver.io
MIT License
18 stars 21 forks source link

Update Hooks to Cucumber V3 #37

Closed BenoitAverty closed 7 years ago

BenoitAverty commented 7 years ago

Close #35

This is a follow-up to PR #36 since @dcypherthis does not seem to have time to finish. I have taken his commit and added a change for backward compatibility.

I am currently in the train with a very limited connectivity so I have not been able to test his yet, but the change is pretty trivial and I had previously tested the change of PR #36 (it worked fine)

If you don't fell confident about the change, feel free to wait until next week, I should be able to do a quick test.

Thanks again to @dcypherthis for the initial diagnosis of the problem and implementation.

jsf-clabot commented 7 years ago

CLA assistant check
All committers have signed the CLA.

BenoitAverty commented 7 years ago

The change should be backwards compatible, this is the difference with #36.

BenoitAverty commented 7 years ago

Hello @christian-bromann, do you know when this might be released ? Thanks in advance !

adenflorian commented 7 years ago

@christian-bromann Will this be published to npm soon? Thanks.

christian-bromann commented 7 years ago

@BenoitAverty @AdenFlorian just published v0.4.1 sorry for the delay