search

webdriverio-boneyard / wdio-sauce-service

WebdriverIO v4 service for better Sauce Labs integration
http://webdriver.io
MIT License
18 stars 21 forks source link

fix: Add null check to getFailureException call #45

Closed mDalessandro closed 6 years ago

mDalessandro commented 6 years ago

Closes #44

jsf-clabot commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Matthew D'Alessandro seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

mDalessandro commented 6 years ago

Hello! I've accepted the Contributor License Agreement.

christian-bromann commented 6 years ago

It still says Contributor License Agreement is not signed yet. .. did you signed it with the right email address?

mDalessandro commented 6 years ago

For the CLA, I used the email address associated with my github, but I think there is a different email associated with the commit. I can't edit the CLA anymore.

Edit: I've added the email associated with the commit to my github account, as the instructions above mention. Do I need to resign the CLA with the commit email?

christian-bromann commented 6 years ago

Do I need to resign the CLA with the commit email?

Yes, feel free to just create a new PR