webdriverio-boneyard / wdio-spec-reporter

A WebdriverIO v4 plugin. Reporter that creates 'spec'-style reports
http://webdriver.io
MIT License
20 stars 26 forks source link

Output saucelabs test url if using wdio-sauce-service #75

Closed billylam closed 6 years ago

billylam commented 6 years ago

Fix for https://github.com/webdriverio/wdio-sauce-service/issues/47

The error seems to occur because the check in reporter looks for config.host to be saucelabs.com, but wdio-sauce-service sets config.host to localhost at https://github.com/webdriverio/wdio-sauce-service/blob/master/lib/sauce-launch-service.js#L18

I can fix it there instead but I don't know the ramifications of that across all projects.

jsf-clabot commented 6 years ago

CLA assistant check
All committers have signed the CLA.

billylam commented 6 years ago

Done

christian-bromann commented 6 years ago

Released as v0.1.4

billylam commented 6 years ago

@christian-bromann It seems after running npm update wdio-spec-reporter, I see this change in lib/reporter.js but not build/reporter.js. Am I missing something?