search

webdriverio-boneyard / wdio-sync

A WebdriverIO v4 plugin. Helper module to run WebdriverIO commands synchronously.
http://v4.webdriver.io
MIT License
17 stars 31 forks source link

Ensure pending test title is correctly identified #15

Closed georgecrawford closed 8 years ago

christian-bromann commented 8 years ago

Was this actually causing any problems? Don't really see the advantage of this change.

georgecrawford commented 8 years ago

Mocha tests with skip get called with a single argument, specTitle. If we indiscriminately pop or shift the arguments array to find a function, we lose this argument, and the resulting specTitle is undefined.

Incidentally, this method seems very bound to Mocha, so we might need to move some of this logic into the Mocha adapter. But that can wait.

georgecrawford commented 8 years ago

Tests for wdio-mocha-framework now pass against this PR.

christian-bromann commented 8 years ago

:+1: