search

webdriverio-boneyard / wdio-sync

A WebdriverIO v4 plugin. Helper module to run WebdriverIO commands synchronously.
http://v4.webdriver.io
MIT License
17 stars 31 forks source link

Announce namespaced commands as 'namespace.fnName' #19

Closed georgecrawford closed 8 years ago

christian-bromann commented 8 years ago

Can you give me a bit context to this change?

georgecrawford commented 8 years ago

The commandName value is only used to announce the command with the beforeCommand and afterCommand hooks. It's useful for these hooks to also receive the namespace, so they can properly identify which command was run (e.g. differentiating browser.url() from browser.mynamespace.url()). These hooks now get url and namespace.url as the command name.

christian-bromann commented 8 years ago

:+1: