search

webdriverio-boneyard / wdio-sync

A WebdriverIO v4 plugin. Helper module to run WebdriverIO commands synchronously.
http://v4.webdriver.io
MIT License
17 stars 31 forks source link

Fixes reference to undefined #52

Closed jmnsf closed 7 years ago

jmnsf commented 7 years ago

Fixes https://github.com/webdriverio/wdio-sync/issues/51

jmnsf commented 7 years ago

@christian-bromann I would, normally, but the function isn't exported. Also, I would wager that an array of undefineds might be symptom of a bug elsewhere.

Honestly this is more of a hotfix since the exception is breaking my test suite through no fault of my own. Worse, it's a package that's depended on by wdio-mocha-framework which makes it a bit of a pain to fix through git installs...

Feel free to edit this PR and add tests that handle this, but I would really appreciate a fast merge on what is essentially a defensive programming patch.

christian-bromann commented 7 years ago

but the function isn't exported

Let's export it into a helper file then.

I would really appreciate a fast merge on what is essentially a defensive programming patch.

I agree with you .. however I see a value in having this covered in unit tests. I can take care of it but you will have to wait until I have time to work on that

jmnsf commented 7 years ago

@christian-bromann then if you don't get to it in the meantime, I'll have a look later today

jmnsf commented 7 years ago

@christian-bromann Done. Had to update the rewrite plugin because of a bug.

jmnsf commented 7 years ago

@christian-bromann ready

christian-bromann commented 7 years ago

Will release this version with updated framework adapter later today

jmnsf commented 7 years ago

Awesome, thank you ;)

jmnsf commented 7 years ago

@christian-bromann hey, could we have this published soon, we're stuck on older package versions until then :)