search

webdriverio-boneyard / wdio-sync

A WebdriverIO v4 plugin. Helper module to run WebdriverIO commands synchronously.
http://v4.webdriver.io
MIT License
17 stars 31 forks source link

Fix error in addCommand method #71

Closed ostapenko-me closed 7 years ago

ostapenko-me commented 7 years ago

Hello!

This pull request fixes a bug #1539 in webdriverio.

I wrote tests for this bug and check the corrected version on my project and I ran integration tests in wdio-mocha-framework. Everything works correctly, and it's cool :)

Can you please accept this pull request, update the wdio-sync package and update the version of wdio-sync in wdio-mocha-framework?

ostapenko-me commented 7 years ago

I also found that these fixes solve issue #1796 in webdriverio. Keep this in mind ;)

christian-bromann commented 7 years ago

Keep this in mind ;)

I am sure I tried to implement it that way but it was not working for some reasons. Thanks for the PR. I will have to take a closer look tho.

monolithed commented 7 years ago

@christian-bromann, hi! Is there anything we can do to speed the merge process along?

christian-bromann commented 7 years ago

Merging, even though I am afraid I tried it this way and it caused something else to break. Will see how this turns out.