webdriverio-boneyard / wdio-sync

A WebdriverIO v4 plugin. Helper module to run WebdriverIO commands synchronously.
http://v4.webdriver.io
MIT License
17 stars 31 forks source link

An in-range update of should is breaking the build 🚨 #95

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 13.1.0 of should just got published.

Branch Build failing 🚨
Dependency should
Current Version 13.0.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As should is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this :muscle:

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build could not complete due to an error [Details](https://travis-ci.org/webdriverio/wdio-sync/builds/277792138?utm_source=github_status&utm_medium=notification)

Release Notes 13.1.0

New

  1. Now all zero argument assertions throw TypeError in case any argument passed to them.
  2. Aliased .fulfill/.fulfilledWith to .resolve/.resolvedWith`

Fixes

  1. TS definition fixed to allow such imports:
import should from 'should';
Commits

The new version differs by 6 commits.

  • c807e9d Release 13.1.0
  • 8acfba1 Merge pull request #154 from citizensas/master
  • c12afd0 chore: should has no default export
  • 4a846b1 Fill history
  • f5c9cc3 Added check for zero argument assertions.
  • fe6b136 Added .resolved, .resolvedWith as aliases to .fulfilled, .fulfilledWith

See the full diff

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 7 years ago

After pinning to 13.0.1 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.