webdriverio-community / wdio-chromedriver-service

WebdriverIO service to start & stop ChromeDriver
MIT License
36 stars 26 forks source link

Transition package from CJS to ESM #78

Closed christian-bromann closed 2 years ago

christian-bromann commented 2 years ago

As part of the v8 effort we are currently migrating over to ESM as many packages will stop support CJS in the future. This means we have to transition all plugins to ESM as well, ideally with continuous support for CJS.

RossVertizan commented 2 years ago

I'll take a look at this one.

christian-bromann commented 2 years ago

Update: my initial assumption that CJS services/reporters would stop working when running WebdriverIO within ESM context is wrong. They continue to work as is without any changes required. However I still suggest to do this ESM transition eventually as dependencies might migrate to ESM and stop working. Given WebdriverIO dynamically imports services and plugins there is no need to build a hybrid package for CJS and ESM. Plugins can just export ESM code and it will work fine for users running CJS and ESM.

christian-bromann commented 2 years ago

Implemented in #83