webdriverio-community / wdio-electron-service

WebdriverIO service for testing Electron applications
https://webdriver.io
MIT License
32 stars 14 forks source link

Update service for WDIO v9 #533

Closed goosewobbler closed 1 week ago

goosewobbler commented 4 months ago

WDIO v9 is coming along nicely, there is a bit of work to do in the service around this, since we are dropping Node 16 I think we cut a major version and punt the IPC bridge replacement to v8.

Tasks:

https://github.com/webdriverio/webdriverio/issues/10362

seanpoulter commented 4 months ago

Is the plan to make a v8 branch and keep v9 development on main?

goosewobbler commented 4 months ago

Yes, I'd have the WDIO v9 version on main which corresponds to v7 of the service. I'd probably name the legacy version branch wdio-v8 or v6 to avoid confusion as the service major versions don't match the WDIO ones. I'm not planning on backporting anything at the moment, but it could be useful to keep around. I don't think WDIO v9 will affect the service anywhere near as much as previous major versions did.

goosewobbler commented 1 month ago

I created the wdio-v8 branch in case we need to backport anything to 6.x.

main will require WDIO v9 when #443 and #666 are merged, and will be released as v7.

goosewobbler commented 1 month ago

Re-opened to keep track of the remaining tasks for the release.

goosewobbler commented 1 month ago

@christian-bromann I need to publish the dependent packages to get the pre-releases for the service working, I was considering to publish them as @wdio-electron/types and @wdio-electron/utils for which we need the @wdio-electron org; I was going to create this org but thought I'd check first, maybe you should create it and I can join.

Or perhaps publishing them under the main org as @wdio/electron-types and @wdio/electron-utils is better?

christian-bromann commented 1 month ago

Or perhaps publishing them under the main org as @wdio/electron-types and @wdio/electron-utils is better?

Yes, no need to create another org, let's use @wdio/ to which you can publish to through the bot.

goosewobbler commented 1 month ago

Finally got a working pre-release in 7.0.0-beta.9. Tested in wdio-electron-service-example.

goosewobbler commented 2 weeks ago

electron-boilerplate is still broken on v9 branch, I'll release anyway as the service works in wdio-electron-service-example.

christian-bromann commented 2 weeks ago

Let me take a look at the boilerplate, I will ping you if I don't know what is going on.

christian-bromann commented 2 weeks ago

It seems like 7.0.0-beta.11 didn't get pushed to NPM 🤔 However I got the boilerplate working with 7.0.0-beta.10 (there was a bug in Stencil that I fixed but which hasn't been released yet, so reverting that version to v4.18.3 fixed the build).

goosewobbler commented 2 weeks ago

There's still something up with the release and pre-release workflows, maybe the dry run is creating tags for some reason...

https://github.com/webdriverio-community/wdio-electron-service/actions/runs/10463303622/job/28975088177 https://github.com/webdriverio-community/wdio-electron-service/actions/runs/10462686326/job/28973369345

goosewobbler commented 2 weeks ago

Reverted to beta.11 and deleted the unused 7.0.0 tag on github, this time I went straight for the full release instead of a dry run followed by full release, it just attempted to release beta.11 again (instead of 7.0.0) 🤔

https://github.com/webdriverio-community/wdio-electron-service/actions/runs/10463968883/job/28976808705

goosewobbler commented 2 weeks ago

Reopening until we get the full release done, I think we're missing some steps from the release-it monorepo recipe:

https://github.com/release-it/release-it/blob/main/docs/recipes/monorepo.md

goosewobbler commented 1 week ago

Release is done, just need to update electron-boilerplate.

Raised https://github.com/webdriverio/electron-boilerplate/pull/224