jQuery converted into vanillaJS and jquery.min.js is removed

[Askarov5]

Issue: #50

I would like to share fully functional only one HTML report file, but because of the (imported) jQuery file it was not fully functional when I share the (master-report)html.

What does this implement/fix?:

jQuery code is converted into pure javascript(vanillaJs) and jQuery.min.js file is removed.

[rpii]

Hi, thanks for the efforts. I am looking at this and testing for regressions. I have no issue with merging it when its fully functional I am working through the branch losing the icon on the suite level popout. Have seen the issue, but no time to debug it for a few days

[rpii]

Ok I merged some changes in to fix the test expansion. Can you try it with your use case?

[Askarov5]

Hi, I'm trying to download updated version but I can not see the changes in branches. which branch did you merge?

[rpii]

Its in your pull request branch. its not merged yet

On Fri, May 7, 2021 at 1:05 PM Orozbek Askarov @.***> wrote:

Hi, I'm trying to do pull request but I can not see the changes in branches. which branch did you merge? So, I can download the updated version and test.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rpii/wdio-html-reporter/pull/52#issuecomment-834740876, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEABIEPXELHTUMCB3PAGFKLTMRBWNANCNFSM44FBA6OQ .

[Askarov5]

Then how can I get the updated version to test? I see you also edited/added. Otherwise, if you tested, just merge it.

[rpii]

just repull from your repo to where you developed it at.

Rich

On Fri, May 7, 2021 at 3:53 PM Orozbek Askarov @.***> wrote:

Then how can I get the updated version to test? I see you also edited/added.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rpii/wdio-html-reporter/pull/52#issuecomment-834837025, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEABIEMVQU7N3WKX4E7PUDDTMRVJ3ANCNFSM44FBA6OQ .

[rpii]

so the if block is standard handlebars. Could be you need to define collapseTests: true, (or false) in tehereport aggregator ctor. not sure why that would fail. I will look into it, but have no safari. can you push the changes you want for toggle tests. I will pull them and take a look.

On Fri, May 7, 2021 at 6:08 PM Orozbek Askarov @.***> wrote:

@Askarov5 commented on this pull request.

Yeah, it worked. There're two issues I can see so far.

In templates/wdio-html-reporter-template.hbs https://github.com/rpii/wdio-html-reporter/pull/52#discussion_r628622092 :

• {{#ifCollapseTests}}
• $('.test-header').click();
• {{/ifCollapseTests }}
• let expandable = document.querySelector('.expandable-control');
• if (expandable) {
• expandable.addEventListener('click', event => {
• event.currentTarget.querySelector('span').classList.toggle('glyphicon-chevron-down');
• event.currentTarget.querySelector('span').classList.toggle('glyphicon-chevron-up');
• let panel = event.currentTarget.nextElementSibling.querySelector('.pre.stack.panel');
• slideToggle(panel, 100);
• });
• }
• if ({{#ifCollapseTests}}{{/ifCollapseTests }}) {

Tested in safari The following if block is breaking the code:

    if ({{#ifCollapseTests}}{{/ifCollapseTests }}) {

Error shown on the console is: SyntaxError: Unexpected token '{'. Expected a property name. [image: Screen Shot 2021-05-07 at 6 43 45 PM] https://user-images.githubusercontent.com/13361800/117518580-e694c800-af65-11eb-8c64-92f40aa67ffe.png

In templates/wdio-html-reporter-template.hbs https://github.com/rpii/wdio-html-reporter/pull/52#discussion_r628634624 :

• document.querySelector('.togglePassingTests').addEventListener('click', event => {
• document.querySelectorAll('.suite-pass').forEach(item => {
• if (item.parentElement.querySelector('span').classList.contains('glyphicon-chevron-up')) {
• item.parentElement.querySelector('span').classList.remove('glyphicon-chevron-up');

We need to fix togglePassingTests button action(same with the toggleFailingTests): When Test Suite is Slide down(open) if we click on the "HidePassedTests" button, then it's closing only test suite header, but test cases are remaining open and visible.

My solution was: do not chevron-up class from span and just toggle chevron-down class

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rpii/wdio-html-reporter/pull/52#pullrequestreview-654929409, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEABIENMGLVXCFHZCKNLWXDTMSFHHANCNFSM44FBA6OQ .

[rpii]

Ok, made some updates. Try it out if you can. would like to merge soon

[Askarov5]

Hi Rich, Thank you. Everything is working on my side. Tested in chrome, Firefox and safari. Ready for production.

QQ: not related to this topic. I always run tests against multiple browsers and always see the following field empty is this a bug or configuration issue.

[rpii]

you must set that in your test as it is not available to be queried until too late in the flow

On Wed, May 19, 2021 at 9:31 PM Orozbek Askarov @.***> wrote:

Hi Rich, Thank you. Everything is working on my side. Tested in chrome, Firefox and safari. Ready for production.

QQ: not related to this topic. I always run tests against multiple browsers and always see the following field empty is this a bug or configuration issue. [image: Screen Shot 2021-05-19 at 11 27 06 PM] https://user-images.githubusercontent.com/13361800/118919464-2e1e3b00-b8fa-11eb-8c66-a06fd0ad8f58.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rpii/wdio-html-reporter/pull/52#issuecomment-844678287, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEABIEPWHR4BYUTCRHRMCFDTOSGA7ANCNFSM44FBA6OQ .

[rpii]

Merging so we can get some better testing