Closed strmer15 closed 3 years ago
ooops my bad. hadnt tested on linux yet. Its fixed now
Thanks for the quick fix @rpii !
no problem. was trying to get it out there too fast
On Thu, Jul 1, 2021 at 8:49 AM Chris Plummer @.***> wrote:
Thanks for the quick fix @rpii https://github.com/rpii !
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rpii/wdio-html-reporter/issues/61#issuecomment-872355783, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEABIENCOFYSEAPPKRYXHALTVSE6HANCNFSM47U66O2Q .
@rpii Sorry to bother you again, but it seems like it's still incorrect - the 7.7.10
package that I just grabbed still has the wrong file case in it. I blew my node_modules
away and reinstalled just to be sure, but it's still there. I verified that the package.json
has the new version and the README
has the new update, but the file name is still incorrect in the published package.
Also, your repository URL in package.json
says "url": "git+ssh://git@github.com/%40rpii/wdio-html-reporter.git"
, looks like you need to remove the %40
in it.
Chris, when I rebuilt it it kept the lower case name since it was on windows. I had to clean everything and rebuild the lib folder to get it correct v11 should be good.
On Thu, Jul 1, 2021 at 9:18 AM Chris Plummer @.***> wrote:
Also, your repository URL in package.json says "url": "git+ssh:// @.***/%40rpii/wdio-html-reporter.git", looks like you need to remove the %40 in it.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rpii/wdio-html-reporter/issues/61#issuecomment-872378677, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEABIEOTVXBLBLSHNGHIJ23TVSIJXANCNFSM47U66O2Q .
Yay, looks good now 🎉 Thanks again, Rich!
In https://github.com/rpii/wdio-html-reporter/commit/5a4aa6b81eac6c98a68ba99d5ea0429b6077d6a8, a new
import
was added to thecopyFiles
module - however, it's giving an error in our build system, since the file name is actuallycopyfiles.ts
and notcopyFiles.ts
. My guess is that our docker instances have a case-sensitive file system and can't locate the file name correclty.Please update https://github.com/rpii/wdio-html-reporter/blob/master/src/reportAggregator.ts#L9 to say
import copyFiles from "./copyFiles";
or renamecopyfiles.ts
tocopyFiles.ts
.