Closed owens-ben closed 2 years ago
owens-ben
commented
2 years ago @rpii
I will! :) I just noticed my commits were a bit messy. And I also want to test it out in my own implementation first before I merge possibly breaking changes to your project.
Is it an issue adding the dependency? It seemed like the easiest way to get around the limits of JSON.stringify()
Nice project btw 💯 Use it all the time
rpii
commented
2 years ago I looked at fixing this earlier but didnt find a simple json streaming solution. This looks good. just fix the package names and a pull request will work just fine.
Rich
On Thu, Mar 17, 2022 at 2:16 PM owens-ben @.***> wrote:
@rpii https://github.com/rpii
I will! :) I just noticed my commits were a bit messy. And I also want to test it out in my own implementation first before I merge possibly breaking changes to your project.
Is it an issue adding the dependency? It seemed like the easiest way to get around the limits of JSON.stringify()
Nice project btw 💯 Use it all the time
— Reply to this email directly, view it on GitHub https://github.com/rpii/wdio-html-reporter/pull/83#issuecomment-1071506575, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEABIENAZUWWNOWH2TNWBJDVAOOHBANCNFSM5Q7WO6XQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
Ben
Thanks for the changes
why dont you make a pull request? I cant ,merge your fork directly as you have renamed the package.
Rich
On Thu, Mar 17, 2022 at 11:43 AM owens-ben @.***> wrote: