search

webdriverio-community / wdio-html-reporter

Fork of wdio-html-format-reporter
MIT License
18 stars 27 forks source link

use big-json for report generation #84

Closed owens-ben closed 2 years ago

owens-ben commented 2 years ago

@rpii hopefully this is all good. Highly recommend you test it on your end, while it works on mine its clear different shapes / sizes of JSON files can cause issues.

rpii commented 2 years ago

So are you thinking that the stringify in HtmlReporter is ok? You had deleted those before.

We can remove those if necessary.

Rich

On Fri, Mar 18, 2022 at 10:16 AM owens-ben @.***> wrote:

@rpii https://github.com/rpii hopefully this is all good. Highly recommend you test it on your end, while it works on mine its clear different shapes / sizes of JSON files can cause issues.

— Reply to this email directly, view it on GitHub https://github.com/rpii/wdio-html-reporter/pull/84#issuecomment-1072618352, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEABIEL6344YXPRVQ6FECSTVAS2ZBANCNFSM5RCLYZ5Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

owens-ben commented 2 years ago

So are you thinking that the stringify in HtmlReporter is ok? You had deleted those before. We can remove those if necessary. Rich …

Yes, those are fine. The only error I had was that it was JSON.stringify, no line number. I had to eliminate them one by one until I found the culprit. I think they're fine for debugging. That's why I closed the original PR, I forgot I had those extraneous changes.

Also just wondering when you'll release the new version?

rpii commented 2 years ago

working through it now, trying to run my test cases. I am currently getting empty report.json files. Havent had time to debug it yet.

I will release it as soon as I can

Rich

On Fri, Mar 18, 2022 at 11:24 AM owens-ben @.***> wrote:

So are you thinking that the stringify in HtmlReporter is ok? You had deleted those before. We can remove those if necessary. Rich … <#m-989247793006549658> On Fri, Mar 18, 2022 at 10:16 AM owens-ben @.> wrote: @rpii https://github.com/rpii https://github.com/rpii https://github.com/rpii hopefully this is all good. Highly recommend you test it on your end, while it works on mine its clear different shapes / sizes of JSON files can cause issues. — Reply to this email directly, view it on GitHub <#84 (comment) https://github.com/rpii/wdio-html-reporter/pull/84#issuecomment-1072618352>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEABIEL6344YXPRVQ6FECSTVAS2ZBANCNFSM5RCLYZ5Q https://github.com/notifications/unsubscribe-auth/AEABIEL6344YXPRVQ6FECSTVAS2ZBANCNFSM5RCLYZ5Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.>

Yes, those are fine. The only error I had was that it was JSON.stringify, no line number. I had to eliminate them one by one until I found the culprit. I think they're fine for debugging. That's why I closed the original PR, I forgot I had those extraneous changes.

Also just wondering when you'll release the new version?

— Reply to this email directly, view it on GitHub https://github.com/rpii/wdio-html-reporter/pull/84#issuecomment-1072677336, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEABIENGPUICT5CTLSIZXGTVATCZ3ANCNFSM5RCLYZ5Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

rpii commented 2 years ago

Ben,

Ive got it working. had to make a few changes, the stream read needs to finish or partial files happen. I committed it. go ahead and pull and test. it should work. passed my tests, but I dont have a huge one test test.

Rich

On Fri, Mar 18, 2022 at 12:34 PM Rich Peters @.***> wrote:

working through it now, trying to run my test cases. I am currently getting empty report.json files. Havent had time to debug it yet.

I will release it as soon as I can

Rich

On Fri, Mar 18, 2022 at 11:24 AM owens-ben @.***> wrote:

So are you thinking that the stringify in HtmlReporter is ok? You had deleted those before. We can remove those if necessary. Rich … <#m_9090668208957213545m-989247793006549658_> On Fri, Mar 18, 2022 at 10:16 AM owens-ben @.> wrote: @rpii https://github.com/rpii https://github.com/rpii https://github.com/rpii hopefully this is all good. Highly recommend you test it on your end, while it works on mine its clear different shapes / sizes of JSON files can cause issues. — Reply to this email directly, view it on GitHub <#84 (comment) https://github.com/rpii/wdio-html-reporter/pull/84#issuecomment-1072618352>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEABIEL6344YXPRVQ6FECSTVAS2ZBANCNFSM5RCLYZ5Q https://github.com/notifications/unsubscribe-auth/AEABIEL6344YXPRVQ6FECSTVAS2ZBANCNFSM5RCLYZ5Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.>

Yes, those are fine. The only error I had was that it was JSON.stringify, no line number. I had to eliminate them one by one until I found the culprit. I think they're fine for debugging. That's why I closed the original PR, I forgot I had those extraneous changes.

Also just wondering when you'll release the new version?

— Reply to this email directly, view it on GitHub https://github.com/rpii/wdio-html-reporter/pull/84#issuecomment-1072677336, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEABIENGPUICT5CTLSIZXGTVATCZ3ANCNFSM5RCLYZ5Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

owens-ben commented 2 years ago

@rpii all good! Would be great if you could release ASAP

rpii commented 2 years ago

I published it. no chance to check that out.

Rich

On Mon, Mar 21, 2022 at 6:37 AM owens-ben @.***> wrote:

@rpii https://github.com/rpii all good! Would be great if you could release ASAP

— Reply to this email directly, view it on GitHub https://github.com/rpii/wdio-html-reporter/pull/84#issuecomment-1073907271, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEABIEPQONB2XH6Q56XAPBLVBB3QNANCNFSM5RCLYZ5Q . You are receiving this because you were mentioned.Message ID: @.***>