Use WebdriverIOs driver setup mechanism

webdriverio-community / wdio-vscode-service

A service to test VSCode extensions from end to end using WebdriverIO

https://webdriverio-community.github.io/wdio-vscode-service/

MIT License

29 stars 23 forks source link

Use WebdriverIOs driver setup mechanism #105

Closed seanpoulter closed 5 months ago

seanpoulter commented 5 months ago

Context

This is my attempt to drive #94 ahead. I believe your branch was very close and mostly needed to set the browserVersion.

Proposed Changes

Remove npm packges for chromedriver and wdio-chromedriver-service
Use WebdriverIO's setup mechanism
- Do not download ChromeDriver
Remove unused utilities

Questions

Would you rather review on a call?
What do we need to do to support Chromium/ChromeDriver v114? The pipeline fails for v1.83.
Should we make the peer dependency on webdriverio explicitly ^8.14.0?
Want a separate PR to update dependencies? It looks like that was folded into #94 as well but I didn't include it to try to simplify the change.
Would you prefer to keep the ServiceCapability interface?

christian-bromann commented 5 months ago

Can we update the CI tests to run on VS Code v1.84 minimum? This should hopefully resolve the problem. I think we need to set the minimum VS Code version to the one that runs on Chromium 115 and make this a breaking change.

seanpoulter commented 5 months ago

Will do.

I'm curious, if you did need to support older versions would you be able to keep wdio-chromedriver-service and it'd override the core implementation?

christian-bromann commented 5 months ago

Yeah .. maybe we can include a section with some information about it, e.g. adding chromedriver to the package.json and add it as service. Not sure how straightforward it is.

seanpoulter commented 5 months ago

Ah, 1.85 is looking for Chromedriver 114. The VS Code manifests confirm that it uses v118 in 1.86.0.

christian-bromann commented 5 months ago

💚

Can we add some documentation about the versioning?

seanpoulter commented 5 months ago

I've updated the docs. The pipeline failure is a timeout at line 20578.

seanpoulter commented 5 months ago

This should close #101.

It no longer closes #97 (update deps). Let me know which deps and I'll get a PR up for that too.

wdio-bot commented 5 months ago

Hey seanpoulter 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day, The WebdriverIO Team 🤖

christian-bromann commented 5 months ago

Released as part of v6.0.0!