search

webdriverio-community / wdio-vscode-service

A service to test VSCode extensions from end to end using WebdriverIO
https://webdriverio-community.github.io/wdio-vscode-service/
MIT License
33 stars 28 forks source link

Make executeWorkbench work after VSCode restarts #106

Closed ilia-db closed 7 months ago

ilia-db commented 7 months ago

vscode.openFolder can be used to restart the VSCode under different workspace root. In that case the current socket is closed, and then the new connection appears after the VSCode is up again.

This PR clears pending message callbacks when the connection is closed and re-assigns the _promisedSocket to a new socket when new connection appears.

Fixes https://github.com/webdriverio-community/wdio-vscode-service/issues/62

Had to hard-code vscode version to 1.85.2 when running tests locally, since newer chromedriver versions live in a new location. Seems like there's a PR already to fix it https://github.com/webdriverio-community/wdio-vscode-service/pull/105

wdio-bot commented 7 months ago

Hey ilia-db 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day, The WebdriverIO Team 🤖

christian-bromann commented 7 months ago

Released as part of v6.0.0!