search

webdriverio-community / wdio-vscode-service

A service to test VSCode extensions from end to end using WebdriverIO
https://webdriverio-community.github.io/wdio-vscode-service/
MIT License
29 stars 23 forks source link

Fix problems with cachePath service option #107

Closed ilia-db closed 5 months ago

ilia-db commented 5 months ago

Using the vscode service with the cachePath option:

services: [["vscode", {cachePath: "/tmp/wdio-vscode-service"}]],

On the 6.0.0 version this results in a failure to run tests:

ERROR @wdio/runner: Error: Invalid or unsupported WebDriver capabilities found ("cachePath"). Ensure to only use valid W3C WebDriver capabilities (see https://w3c.github.io/webdriver/#capabilities).If you run your tests on a remote vendor, like Sauce Labs or BrowserStack, make sure that you put them into vendor specific capabilities, e.g. "sauce:options" or "bstack:options". Please reach out to your vendor support team if you have further questions.

cachePath is indeed not a capability based on any of the wdio or webdriver types.

Looking at the old 5.* code, assigning options to the capabilities made sense because options field actually contained different things in the wdio-chromedriver-service/launcher base class.

Right now the options are only relevant for the vscode service, so I've removed all logic that merges them into capabilities.

seanpoulter commented 5 months ago

Oh no, sorry I didn't catch that in the previous PR. Is it worth adding a test case that uses cachePath? I'm happy to add one after. It doesn't have to block the PR.

seanpoulter commented 5 months ago

The build fails for the same reason as https://github.com/webdriverio/webdriverio/pull/12305. I'll open a PR to bump those dependencies when the workflows pass.

Edit: #108