search

webdriverio-community / wdio-vscode-service

A service to test VSCode extensions from end to end using WebdriverIO
https://webdriverio-community.github.io/wdio-vscode-service/
MIT License
33 stars 28 forks source link

feat: set http proxy from env #87

Closed openscript closed 10 months ago

openscript commented 11 months ago

This is related with #86.

Undici doesn't support http proxies out of the box, but there is a ProxyAgent built in: https://undici.nodejs.org/#/docs/api/ProxyAgent

openscript commented 11 months ago

Hmm.. I think we need to proxy download too.

openscript commented 11 months ago

@vscode/test-electron reads proxy environment variables: https://github.com/microsoft/vscode-test/blob/c4b489f6052f4070839165bb88fcd11263f0460b/lib/util.ts#L60

christian-bromann commented 11 months ago

This is awesome, do you think we can add a sentence or two in the README.md to document this behavior?

openscript commented 11 months ago

This is awesome, do you think we can add a sentence or two in the README.md to document this behavior?

Absolutely :smile:

Is that failing test because of me?

christian-bromann commented 11 months ago

Probably not, I will have to check.