webdriverio-community / wdio-vscode-service

A service to test VSCode extensions from end to end using WebdriverIO
https://webdriverio-community.github.io/wdio-vscode-service/
MIT License
29 stars 23 forks source link

Use WebdriverIOs driver setup mechanism #94

Closed christian-bromann closed 5 months ago

christian-bromann commented 8 months ago

This patch will remove chromedriver and wdio-chromedriver-service in favor of WebdriverIOs own driver setup mechanism.

Note: this currently doesn't work yet as Chrome for testing started to release Chromedriver starting v115. VS Code however currently still relies on v114 for their latest VS Code release.

openscript commented 8 months ago

If I set up a new project via wdio/cli and running wdio config it doesn't add ts-node to my dependencies. Maybe the setup can add it to the package.json.

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'ts-node' imported from /workspaces/monorepo/project
    at new NodeError (node:internal/errors:405:5)
    at packageResolve (node:internal/modules/esm/resolve:887:9)
    at moduleResolve (node:internal/modules/esm/resolve:936:20)
    at defaultResolve (node:internal/modules/esm/resolve:1129:11)
    at nextResolve (node:internal/modules/esm/loader:163:28)
    at ESMLoader.resolve (node:internal/modules/esm/loader:835:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18)
    at ESMLoader.import (node:internal/modules/esm/loader:524:22)
    at initializeLoader (node:internal/process/esm_loader:75:58)
    at loadESM (node:internal/process/esm_loader:90:11) {
  code: 'ERR_MODULE_NOT_FOUND'
}
mattseddon commented 6 months ago

@christian-bromann version 1.86.0 of VS Code shipped with version 118.0.5993.159 of Chromium. Would it be possible to make this change now?

christian-bromann commented 6 months ago

I haven't been able to make progress on this, if anyone wants to push it over the goal line I would appreciate it.

seanpoulter commented 5 months ago

You've got our eyes on it @christian-bromann. How can we help? I'd suggest splitting the changes to the docs/imports out into a small quick PR, and we can focus on the behaviour changes separately.

christian-bromann commented 5 months ago

I hope to be able to take a look at this sometime this week. If you like to take this one feel free.

christian-bromann commented 5 months ago

Closing in favor of #105 ... thanks @seanpoulter 🙌