webdriverio-community / wdio-vscode-service

A service to test VSCode extensions from end to end using WebdriverIO
https://webdriverio-community.github.io/wdio-vscode-service/
MIT License
29 stars 23 forks source link

Contain side-effects from tests in C/I #99

Closed sourishkrout closed 6 months ago

sourishkrout commented 6 months ago

Follow up to https://github.com/webdriverio-community/wdio-vscode-service/pull/98.

sourishkrout commented 6 months ago

Test passed for various vscode versions on a Linux box (in codespaces). Hopefully 🤞 this will make them pass in GH actions, @christian-bromann.

christian-bromann commented 6 months ago

Thanks for the patch 👌

christian-bromann commented 6 months ago

@sourishkrout shouldn't we remove the tests from the basic.e2e.ts since they have been moved out into separate files?

sourishkrout commented 6 months ago

@sourishkrout shouldn't we remove the tests from the basic.e2e.ts since they have been moved out into separate files?

I believe the whole file was removed. If not then I must have done something wrong during commit. Checking....

Also... Windows 🤦.

sourishkrout commented 6 months ago

Looks like this is right:

image
christian-bromann commented 6 months ago

Looks like this is right:

Yes, thanks for confirming. The GitHub UI tricked me here.

sourishkrout commented 6 months ago

Just pushed a wdio config change to turn on retries for occasional flakes @christian-bromann.

christian-bromann commented 6 months ago

I will rerun this a couple of times, knowing that some of these tests aren't stable.

sourishkrout commented 6 months ago

Got one of the culprits to pass consistently locally. Let's see if we can get a clean build, please, @christian-bromann.

sourishkrout commented 6 months ago

Chromedriver/Electron didn't even come up in the last run. Don't think that's related to the new commits. Crashed prematurely.

sourishkrout commented 6 months ago

🤦 whackamole continues

sourishkrout commented 6 months ago

🤞 hopefully this will fix it @christian-bromann