Add WDIO sync -> async codemod

webdriverio / codemod

A codemod to transform Protractor into WebdriverIO tests

MIT License

25 stars 12 forks source link

Closed vgrigoruk closed 2 years ago

vgrigoruk commented 3 years ago

It would be nice to have a codemod that can convert wdio sync code to async.

alk-mandrianarijaona commented 3 years ago

Hello, has anyone started to work on the codemod? This is something I am going to need to I am offering my help

christian-bromann commented 3 years ago

@alk-mandrianarijaona no one has started on this, happy if you can lead this effort.

alk-mandrianarijaona commented 3 years ago

@christian-bromann I have started a draft PR to start collaborating on this

mo commented 2 years ago

I tried this codemode and it got me a little bit on the way but many things needs manual fixups. In particular:

it added double/nested awaits, for example: expect(await (await $('body')).getText()).toContain('Could not find any page matching the specified address.')
it added "async" on each test like for example it('login page loads', async () => { but I use page objects so most of my .click() and .setValue() etc is inside page object functions and those where not made async. Whenever it adds an await in a function, I think it would be good if that function was also made async.

alk-mandrianarijaona commented 2 years ago

@mo would you mind sharing some of your initial code sample so I can do more testing on my side?

WillBrock commented 2 years ago

I expanded off of what @alk-mandrianarijaona started with the codemod if anyone wants to check it out.

alk-mandrianarijaona commented 2 years ago

@WillBrock that looks great, I am gonna test it with some of my files and let you know

bitfrost commented 2 years ago

Any updates on the status of this effort?

christian-bromann commented 2 years ago

I just released this as v0.10.0.