search

webdriverio / query-selector-shadow-dom

querySelector that can pierce Shadow DOM roots without knowing the path through nested shadow roots. Useful for automated testing of Web Components. Production use is not advised, this is for test environments/tools such as Web Driver, Playwright, Puppeteer
MIT License
242 stars 25 forks source link

Should I add support for Protractor? #33

Closed jan-molak closed 4 years ago

jan-molak commented 4 years ago

Hi @Georgegriff and thanks for your amazing query-selector-shadow-dom!

I understand that your motivation behind writing this library was to provide support for Playwright, which now has its own CSS selector engine inspired by your work. In light of this, are you planning to continue to maintain this library?

If the answer is yes, would you be open to me submitting a PR adding support for Angular Protractor?

Thanks, Jan

Georgegriff commented 4 years ago

This library existed before playwright, it's just playwright was the easiest to integrate with recently (until it wasn't needed anymore) But of course, more than happy! Although bare in mind have have zero experience with that test framework. So any examples/background or test cases would be great.

It may also be simpler to derive a new library with this is a dependency, up to you

jan-molak commented 4 years ago

Hi @Georgegriff! Many thanks for merging the PR 👍 Is there anything left to do before we could have the new feature available on NPM?

Georgegriff commented 4 years ago

I'll try to release it today when I get chance

Georgegriff commented 4 years ago

Released in 0.6.0

jan-molak commented 4 years ago

Brilliant, thanks @Georgegriff :shipit: