search

webdriverio / query-selector-shadow-dom

querySelector that can pierce Shadow DOM roots without knowing the path through nested shadow roots. Useful for automated testing of Web Components. Production use is not advised, this is for test environments/tools such as Web Driver, Playwright, Puppeteer
MIT License
242 stars 25 forks source link

[Experimental] Puppeteer Custom Engine support #36

Closed Georgegriff closed 4 years ago

Georgegriff commented 4 years ago

https://github.com/puppeteer/puppeteer/issues/5405

LarsDenBakker commented 4 years ago

@Georgegriff any plans to release this as an experimental option? I copied the changes manually now :)

One suggestion regarding the name, I think something like deep or pierce-shadow would be a bit more descriptive.

Georgegriff commented 4 years ago

I was waiting for it to land in stable puppeteer but I'm open to shipping a version the experience apis.

Yeah the name is tricky,. But the way this is currently implemented the user is complete free to decide on the name instead of shadow. Since the consumer is the one who registers the handler, my library just exposes the queryhandler implementation

LarsDenBakker commented 4 years ago

I'm not sure how long puppeteer plans to have this be experimental, but I think it would be great to offer this option in the meantime. I need it for a project myself, but we should promote this library more in general!

Georgegriff commented 4 years ago

Released under 0.6.1 as experimental feature https://github.com/Georgegriff/query-selector-shadow-dom/releases/tag/0.6.1