webex / webex-js-sdk

JavaScript SDK for Webex

https://webex.github.io/webex-js-sdk/

Other

172 stars 340 forks source link

fix: handle empty TURN url #3516

Closed marcin-bazyl closed 4 months ago

marcin-bazyl commented 4 months ago

COMPLETES #SPARK-513280

This pull request addresses

When we land on video mesh nodes, Linus might return to us an empty TURN url, browsers don't like that.

by making the following changes

Don't pass any TURN server information to the browser if TURN url is empty.

Change Type

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Tooling change
[ ] Internal code refactor

The following scenarios where tested

unit tests

I certified that

[x] I have read and followed contributing guidelines
[x] I discussed changes with code owners prior to submitting this pull request
[x] I have not skipped any automated checks
[x] All existing and new tests passed
[x] I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.