webex / webex-js-sdk

JavaScript SDK for Webex

https://webex.github.io/webex-js-sdk/

Other

172 stars 340 forks source link

fix(plugin-meetings): add streams from simulcasts to media quality events #3528

Closed mccarthytyler closed 4 months ago

mccarthytyler commented 4 months ago

COMPLETES SPARK-509839

This pull request addresses

The absence of simulcast streams from MQEs.

Edit: added sample output and screenshots. New items are located at metrics[0].eventPayload.intervals[0].videoTransmit[0].streams

sample-mqe-output.json

Screenshot 2024-04-17 at 3 10 01 PM

Screenshot 2024-04-17 at 3 10 31 PM

by making the following changes

Adding every outbound stream from a sender to the audioTransmit sender in a MQE.

Change Type

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Tooling change
[ ] Internal code refactor

The following scenarios where tested

Testing that multiple streams appear on an MQE for a single sender.

I certified that

[x] I have read and followed contributing guidelines
[x] I discussed changes with code owners prior to submitting this pull request
[x] I have not skipped any automated checks
[x] All existing and new tests passed
[x] I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.