The skipped tests that we had in the next branch was because they were failing and Catalin needed more time to figure it out. Now that we've moved internal-plugin-metrics to run tests on Mocha itself, we do not have to skip these tests anymore.
by making the following changes
We've removed the skips and ran these tests locally to see them pass.
Change Type
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[x] Tooling change
[ ] Internal code refactor
The following scenarios where tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
COMPLETES AdHoc
This pull request addresses
The skipped tests that we had in the next branch was because they were failing and Catalin needed more time to figure it out. Now that we've moved
internal-plugin-metricsto run tests on Mocha itself, we do not have to skip these tests anymore.by making the following changes
We've removed the skips and ran these tests locally to see them pass.
Change Type
The following scenarios where tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
I certified that
[x] I have read and followed contributing guidelines
[x] I discussed changes with code owners prior to submitting this pull request
[x] I have not skipped any automated checks
[x] All existing and new tests passed
[x] I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.