webex / webex-js-sdk

JavaScript SDK for Webex

https://webex.github.io/webex-js-sdk/

Other

170 stars 336 forks source link

fix(tooling): fix-samples-build-cmd #3579

Closed Shreyas281299 closed 2 months ago

Shreyas281299 commented 2 months ago

COMPLETES #SPARK-513491

This pull request addresses

After https://github.com/webex/webex-js-sdk/pull/3575, to build samples we need /packages/webex/dist/meetings.js

Changed 'yarn run samples:build` command to first build the packages and then build the samples.

Change Type

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[x] Tooling change
[ ] Internal code refactor

The following scenarios where tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

[ ] I have read and followed contributing guidelines
[ ] I discussed changes with code owners prior to submitting this pull request
[ ] I have not skipped any automated checks
[ ] All existing and new tests passed
[ ] I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

aws-amplify-us-east-2[bot] commented 2 months ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3579.d3m3l2kee0btzx.amplifyapp.com