webex / webex-js-sdk

JavaScript SDK for Webex
https://webex.github.io/webex-js-sdk/
Other
169 stars 336 forks source link

fix(plugin-meetings): only log devices when required #3581

Closed shnaaz closed 2 months ago

shnaaz commented 2 months ago

COMPLETES #< INSERT LINK TO ISSUE >

https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-506202

This pull request addresses

< DESCRIBE THE CONTEXT OF THE ISSUE > We always call getDevices() which eventually requests for permissions for camera and microphone even when media is not enabled. This fix will only make a call to getDevices() via handelDeviceLogging when media is enabled.

by making the following changes

< DESCRIBE YOUR CHANGES >

Change Type

The following scenarios where tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that


Make sure to have followed the contributing guidelines before submitting.

aws-amplify-us-east-2[bot] commented 2 months ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3581.d3m3l2kee0btzx.amplifyapp.com