k-wasniowski commented 2 months ago

COMPLETES #SPARK-520529

This pull request addresses

Currently, MultistreamMediaConnection doesn't wait for the ICE Gathering to complete. What results in sometimes not waiting for relay candidates to be gathered. Not waiting for relay candidates to be gathered, may result in not intended media connection failure even though media could be establish through the TurnTLS.

by making the following changes

This PR introduces functionality which on media connection will wait for ICE Gathering to be completed. What's more retry have been added in case ICE Gathering completes in requested time duration, but no DTLS connection have been established yet.

Change Type

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Tooling change
[ ] Internal code refactor

The following scenarios where tested

JS SDK Multistream Connection Establishment JS SDK Transcoded Connection Establishment Web App

I certified that

[x] I have read and followed contributing guidelines
[x] I discussed changes with code owners prior to submitting this pull request
[x] I have not skipped any automated checks
[x] All existing and new tests passed
[x] I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

aws-amplify-us-east-2[bot] commented 2 months ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3587.d3m3l2kee0btzx.amplifyapp.com

k-wasniowski commented 1 month ago

This PR has been moved to the next branch here: https://github.com/webex/webex-js-sdk/pull/3604

webex / webex-js-sdk