webex / webex-js-sdk

JavaScript SDK for Webex

https://webex.github.io/webex-js-sdk/

Other

169 stars 336 forks source link

fix(plugin-meetings): requestedBitrate and requestedFrameSize stats #3594

Closed SomeBody16 closed 1 month ago

SomeBody16 commented 1 month ago

COMPLETES SPARK-491229

This pull request addresses

Missing MQE stats (requestedBitrate, requestedFrameSize) from web client

It's a follow to PR #3526 (previously to beta branch)

by making the following changes

Filled missing stats in statsAnalyzer (plugin-meetings)

Change Type

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Tooling change
[ ] Internal code refactor

The following scenarios where tested

meeting with 2 people using samples:serve correctly reads stats from WCME (logs)
meeting with 2 people using samples:serve correctly sends MQE requested with filled requestedBitrate and requestedFrameSize (curl)

I certified that

[x] I have read and followed contributing guidelines
[x] I discussed changes with code owners prior to submitting this pull request
[x] I have not skipped any automated checks
[x] All existing and new tests passed
[ ] I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

aws-amplify-us-east-2[bot] commented 1 month ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3594.d3m3l2kee0btzx.amplifyapp.com