webex / webex-js-sdk

JavaScript SDK for Webex

https://webex.github.io/webex-js-sdk/

Other

174 stars 343 forks source link

fix(plugin-meetings): streamline is active speaker mqa #3597

Closed edvujic closed 3 months ago

edvujic commented 4 months ago

COMPLETES WEBEX-379504

This pull request addresses

An issue where the isActiveSpeaker property is erroneously set to true within the MQE, regardless of the actual speaker status.

Change Type

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Tooling change
[ ] Internal code refactor

The following scenarios where tested

Changes:

Ensured isActiveSpeaker MQA is accurately propagated from WCME.
Updated JS-SDK to check and mark activeSpeaker MQA as true only if active in the previous interval.

I certified that

[X] I have read and followed contributing guidelines
[X] I discussed changes with code owners prior to submitting this pull request
[X] I have not skipped any automated checks
[X] All existing and new tests passed
[X] I have updated the documentation accordingly

aws-amplify-us-east-2[bot] commented 4 months ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3597.d3m3l2kee0btzx.amplifyapp.com

antsukanova commented 2 months ago

@edvujic thanks for finishing PR!