the issue in current logic of recognizing an exempted domain while populating the Direct Meeting Information. The current logic doesn't recognize that meet-intb.ciscospark.com is still part of the domain ciscospark.com. #2329
Due to the above issue in the logic, we see a problem on Webex Instant Connect during the consultation. Currently, the meeting information is unavailable for the application.
The getDirectMeetingInfoURI function does not use the catalog to populate the URI for fetching the meeting information. It simply tries to validate from an allow list of known domains and appends /wbxappapi/meetingInfo to the URL.
In the Instant Connect, this results in the application sending out a GET https://meet.ciscospark.com/wbxappapi/v1/meetingInfo or GET https://meet-intb.ciscospark.com/wbxappapi/v1/meetingInfo to fetch the meeting information.
Both of the above URLs are incorrect and not present in the catalog. Therefore, this breaks the meeting information in Instant Connect.
by making the following changes
Change the logic to correctly check for a substring so subdomains under the exempted domain array are also covered.
Change Type
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Tooling change
[ ] Internal code refactor
The following scenarios where tested
Try webex.meetings.create('77892476598@meet-intb.ciscospark.com') using an INT token from Instant Connect in our Kitchen Sink and ensure that the meetingInfo object is correctly populated.
Try to generate guest token in Kitchen Sink app and do a webex.meetings.create() for a production webex meeting.
COMPLETES # SPARK-525193
This pull request addresses
the issue in current logic of recognizing an exempted domain while populating the Direct Meeting Information. The current logic doesn't recognize that
meet-intb.ciscospark.com
is still part of the domainciscospark.com
. #2329Due to the above issue in the logic, we see a problem on Webex Instant Connect during the consultation. Currently, the meeting information is unavailable for the application.
The
getDirectMeetingInfoURI
function does not use the catalog to populate the URI for fetching the meeting information. It simply tries to validate from an allow list of known domains and appends /wbxappapi/meetingInfo to the URL. In the Instant Connect, this results in the application sending out aGET https://meet.ciscospark.com/wbxappapi/v1/meetingInfo
orGET https://meet-intb.ciscospark.com/wbxappapi/v1/meetingInfo
to fetch the meeting information.Both of the above URLs are incorrect and not present in the catalog. Therefore, this breaks the meeting information in Instant Connect.
by making the following changes
Change the logic to correctly check for a substring so subdomains under the exempted domain array are also covered.
Change Type
The following scenarios where tested
webex.meetings.create('77892476598@meet-intb.ciscospark.com')
using an INT token from Instant Connect in our Kitchen Sink and ensure that themeetingInfo
object is correctly populated.webex.meetings.create()
for a production webex meeting.Logs and HAR files for working and non-working scenarios: meetingInfo-issue-fix.zip
I certified that
[x] I have read and followed contributing guidelines
[x] I discussed changes with code owners prior to submitting this pull request
[x] I have not skipped any automated checks
[x] All existing and new tests passed
[x] I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.