webex / webex-js-sdk

JavaScript SDK for Webex
https://webex.github.io/webex-js-sdk/
Other
169 stars 336 forks source link

fix(plugin-meetings): fix check for whether domain is exempted #3600

Closed sreenara closed 1 month ago

sreenara commented 1 month ago

COMPLETES # SPARK-525193

This pull request addresses

the issue in current logic of recognizing an exempted domain while populating the Direct Meeting Information. The current logic doesn't recognize that meet-intb.ciscospark.com is still part of the domain ciscospark.com. #2329

Due to the above issue in the logic, we see a problem on Webex Instant Connect during the consultation. Currently, the meeting information is unavailable for the application.

The getDirectMeetingInfoURI function does not use the catalog to populate the URI for fetching the meeting information. It simply tries to validate from an allow list of known domains and appends /wbxappapi/meetingInfo to the URL. In the Instant Connect, this results in the application sending out a GET https://meet.ciscospark.com/wbxappapi/v1/meetingInfo or GET https://meet-intb.ciscospark.com/wbxappapi/v1/meetingInfo to fetch the meeting information.

Both of the above URLs are incorrect and not present in the catalog. Therefore, this breaks the meeting information in Instant Connect.

by making the following changes

Change the logic to correctly check for a substring so subdomains under the exempted domain array are also covered.

Change Type

The following scenarios where tested

  1. Try webex.meetings.create('77892476598@meet-intb.ciscospark.com') using an INT token from Instant Connect in our Kitchen Sink and ensure that the meetingInfo object is correctly populated.
  2. Try to generate guest token in Kitchen Sink app and do a webex.meetings.create() for a production webex meeting.

Logs and HAR files for working and non-working scenarios: meetingInfo-issue-fix.zip

I certified that


Make sure to have followed the contributing guidelines before submitting.

aws-amplify-us-east-2[bot] commented 1 month ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3600.d3m3l2kee0btzx.amplifyapp.com