webex / webex-js-sdk

JavaScript SDK for Webex
https://webex.github.io/webex-js-sdk/
Other
169 stars 336 forks source link

fix(calling): wdm deregister method #3609

Closed mkesavan13 closed 1 month ago

mkesavan13 commented 1 month ago

COMPLETES SPARK-509669

This pull request addresses

2 device registrations occur in the Calling SDK.

While we have the above two methods for deregistering, we do not have a deregister method only for line and not for calling which does the WDM device deletion operation

by making the following changes

Recording

In the below recordings, you can see that the WDM device and Mercury registration doesn't happen before this change and they happen in the after-change screen recording,

Before:

https://github.com/webex/webex-js-sdk/assets/8044050/e7d7bb7a-c03f-4eac-8256-637a4f123419

After:

calling.deregister cleans up active lines automatically and deletes the WDM registration

https://github.com/webex/webex-js-sdk/assets/8044050/b0af4d86-cac5-4a56-b9ae-6d6e84b8437b

calling.deregister just deletes the WDM registration

https://github.com/webex/webex-js-sdk/assets/8044050/2eb4af9f-e965-42b8-a7c6-5a0889e25da1

Change Type

The following scenarios where tested

I certified that


Make sure to have followed the contributing guidelines before submitting.

aws-amplify-us-east-2[bot] commented 1 month ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3609.d3m3l2kee0btzx.amplifyapp.com