webex / webex-js-sdk

JavaScript SDK for Webex

https://webex.github.io/webex-js-sdk/

Other

174 stars 343 forks source link

feat(contacts): import dss plugin for search and cloud contact resolution #3618

Closed sreenara closed 4 months ago

sreenara commented 4 months ago

COMPLETES #NA

This pull request addresses

calling plugin missing dss plugin import due to which we can't utilize dss functions in the calling code.

by making the following changes

requiring the @webex/internal-plugin-dss in calling.js

Change Type

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Tooling change
[ ] Internal code refactor

The following scenarios where tested

Check the presence of the webex.internal.dss object.
Run a test to lookup a user by doing contacts.webex.internal.dss.lookup({id: userId});
Test other calling functionality like making calls.

I certified that

[x] I have read and followed contributing guidelines
[x] I discussed changes with code owners prior to submitting this pull request
[x] I have not skipped any automated checks
[x] All existing and new tests passed
[x] I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.