webex / webex-js-sdk

JavaScript SDK for Webex

https://webex.github.io/webex-js-sdk/

Other

169 stars 336 forks source link

fix(plugin-meetings): backgroundNoiseReductionMode and backgroundAugmentationType MQE #3619

Open SomeBody16 opened 1 month ago

SomeBody16 commented 1 month ago

COMPLETES WEBEX-379501

This pull request addresses

Missing backgroundNoiseReductionMode and backgroundAugmentationType MQE

by making the following changes

[ ] Updated internal-media-core version with populating these stats
[x] Populating these stats in MQE

Change Type

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Tooling change
[ ] Internal code refactor

The following scenarios where tested

[x] automated tests for plugin-meetings
[x] 1:1 meeting correctly sends MQE in network tab

I certified that

[x] I have read and followed contributing guidelines
[x] I discussed changes with code owners prior to submitting this pull request
[x] I have not skipped any automated checks
[x] All existing and new tests passed
[ ] I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

antsukanova commented 2 weeks ago

Lgtm 👍