webex / webex-js-sdk

JavaScript SDK for Webex
https://webex.github.io/webex-js-sdk/
Other
169 stars 336 forks source link

fix(plugin-meetings): Mute issue with host and "mute all" action #3621

Closed antsukanova closed 1 month ago

antsukanova commented 1 month ago

COMPLETES # WEBEX-382445

This pull request addresses

The issue arises from mutedByOthersChanged in selfUtils. This function should not trigger a user mute update when the user receives a notification from the server that the server has been updated remotely to a muted state but not from another person.

by making the following changes

I have added the fix to mutedByOthersChanged that will avoid updating the mute state when the server state doesn't change by others and added testcases for selfUtils.mutedByOthersChanged

Change Type

The following scenarios where tested

I certified that


Make sure to have followed the contributing guidelines before submitting.

aws-amplify-us-east-2[bot] commented 1 month ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3621.d3m3l2kee0btzx.amplifyapp.com

antsukanova commented 1 month ago

Ah, a nice and simple fix. Looks good! Also updated your PR title.

Thanks for the title and review @brycetham!