webex / webex-js-sdk

JavaScript SDK for Webex
https://webex.github.io/webex-js-sdk/
Other
169 stars 336 forks source link

feat(webex-core): adding support for a custom proxy #3624

Open Tiuipuv opened 1 month ago

Tiuipuv commented 1 month ago

This pull request addresses

Adding support for an app to set a custom proxy on all requests. The app can control this by setting the proxy configuration during init. e.g.

webex = WebexSdk.init({
  credentials: {
    supertoken: superToken
  },
  config: {
    credentials: {
      client_id,
      client_secret
    },
    proxy: 'http://proxy.company.com'
  }
});

By allowing for custom proxy it'll be easier for organizations utilizing a proxy to be able to connect to the webex sdk via NodeJS.

by making the following changes

These changes include:

Change Type

The following scenarios where tested

I certified that


Make sure to have followed the contributing guidelines before submitting.

Tiuipuv commented 1 month ago

If this PR is accepted, it is recommended that the proxy documentation on this wiki page be updated to include both the websocket proxy setup as well as this new http proxy setup.

sreenara commented 3 weeks ago

@Tiuipuv, the SDK team will review this PR. Please stand-by.