fix: circular dependency issues

[mkesavan13]

PARTIALLY COMPLETES SPARK-515520

This pull request addresses

Solves the following circular dependencies:

• packages/@webex/internal-plugin-metrics/src/call-diagnostic/call-diagnostic-metrics.ts <-> packages/@webex/internal-plugin-metrics/src/new-metrics.ts
• packages/@webex/internal-plugin-device/src/index.js <-> packages/@webex/internal-plugin-metrics/src/index.ts

by making the following changes

For call-diagnostic-metrics.ts <-> new-metrics.ts,

getOSNameInternal was imported from the whole plugin instead of the internal file. Changed that to import from the internal file

For internal-plugin-device <-> internal-plugin-metrics

Here, the metrics require some device info to be sent to amplitude for which it imports the internal-plugin-device and as part of this PR, we made changes to ensure internal-plugin-device sets the whole device plugin to the call diagnostics metrics on successful registration of a device

Change Type

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Documentation update
• [ ] Tooling change
• [x] Internal code refactor

The following scenarios where tested

• pre-login and post-login metrics scenarios were tested by giving my PMR as URL

This is when I entered my PMR and logged in:

This is when I just loaded localhost:4000/meeting that redirected automatically to localhost:4000/join-a-meeting:

I certified that

• [x] I have read and followed contributing guidelines

• [x] I discussed changes with code owners prior to submitting this pull request

• [x] I have not skipped any automated checks

• [x] All existing and new tests passed

• [x] I have updated the documentation accordingly

---

Make sure to have followed the contributing guidelines before submitting.