webex / webex-js-sdk

JavaScript SDK for Webex
https://webex.github.io/webex-js-sdk/
Other
167 stars 334 forks source link

fix(plugin-meetings): export-meetinginfoutil-as-class #3632

Closed Shreyas281299 closed 4 weeks ago

Shreyas281299 commented 4 weeks ago

COMPLETES #SPARK-502998

This pull request addresses

  1. After PR-3602 all imports were working fine except MeetingInfoUtil. Methods inside MeetingInfoUtil were not accessible directly in web-client What went wrong? Using export * as MeetingInfoUtil from './meeting-info/utilv2'; exported everything under MeetingInfoUtil namespace. To utilize methods in MeetingInfoUtils we would have to do MeetingInfoUtil.default in web-client Fix - import the default export from 'meetingsInfoUtils.ts' and then export the class.

  2. JoinMeetingError was not exported.

by making the following changes

MeetingInfoUtil is accessible as before. JoinMeetingError is exported.

Change Type

The following scenarios where tested

-Locally linked these changes and ran tests in web-client.

Screenshot 2024-06-05 at 11 53 15 PM

I certified that


Make sure to have followed the contributing guidelines before submitting.

aws-amplify-us-east-2[bot] commented 4 weeks ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3632.d3m3l2kee0btzx.amplifyapp.com