webex / webex-js-sdk

JavaScript SDK for Webex
https://webex.github.io/webex-js-sdk/
Other
167 stars 334 forks source link

chore(codeowners): update codeowners file #3640

Closed sreenara closed 3 weeks ago

sreenara commented 3 weeks ago

COMPLETES # NA

This pull request addresses

the issue of the Web SDK team not being added into reviews automatically as codeowners for packages where the Web Client and WCME teams are making changes. The older CODEOWNERS file was fine because the teams were using different branches (beta and master). However, now that all teams are using the next branch, there is a need to be careful about breaking changes which can cause issues in applications consuming the SDK (Webex Web Client, Instant Connect, Widgets, 3rd party developer applications).

by making the following changes

Update @webex/web-sdk as owner for @webex/plugin-meetings, @webex/internal-plugin-voicea and all their dependent packages as these are the main packages that the SDK team needs notifications on.

Change Type

The following scenarios where tested

NA

I certified that


Make sure to have followed the contributing guidelines before submitting.

sreenara commented 3 weeks ago
  1. Since we are the calling owners, we can specify ourselves as Code Owners there
  2. Considering that, we should also ensure if the packages that Calling depend on are also explicitly specified

Looks good otherwise

We'd fall under the default rule of * since we are the Web SDK team right? The codeowners file says "Web SDK Team Ownership *". Calling comes under this, so it should be ok? If we create a separate rule for calling, then in the future we would have to create rules for all other plugins we are creating.

Calling only depends on @webex/media-helpers and that's added in the codeowners file.

mkesavan13 commented 3 weeks ago
  1. Since we are the calling owners, we can specify ourselves as Code Owners there
  2. Considering that, we should also ensure if the packages that Calling depend on are also explicitly specified

Looks good otherwise

We'd fall under the default rule of * since we are the Web SDK team right? The codeowners file says "Web SDK Team Ownership *". Calling comes under this, so it should be ok? If we create a separate rule for calling, then in the future we would have to create rules for all other plugins we are creating.

Calling only depends on @webex/media-helpers and that's added in the codeowners file.

If we do not mention it specifically, it does ask for a review from us but, it doesn't ask for approval from our team and Calling needs approval from us for sure, right?

sreenara commented 3 weeks ago
  1. Since we are the calling owners, we can specify ourselves as Code Owners there
  2. Considering that, we should also ensure if the packages that Calling depend on are also explicitly specified

Looks good otherwise

We'd fall under the default rule of * since we are the Web SDK team right? The codeowners file says "Web SDK Team Ownership *". Calling comes under this, so it should be ok? If we create a separate rule for calling, then in the future we would have to create rules for all other plugins we are creating. Calling only depends on @webex/media-helpers and that's added in the codeowners file.

If we do not mention it specifically, it does ask for a review from us but, it doesn't ask for approval from our team and Calling needs approval from us for sure, right?

Please see #3641 which requires a review and approval from the Web SDK team for calling change.