Closed mkesavan13 closed 2 weeks ago
The PR description says "COMPLETES AdHoc" - we're missing a jira link here
The PR description says "COMPLETES AdHoc" - we're missing a jira link here
~We do not have a Jira for this. I took it as an Adhoc activity to fix this @marcin-bazyl~
Added the SPARK link
COMPLETES SPARK-533903
This pull request addresses
Instant connected reported that, the
moveTo
API doesn't unpublish the localStreams. This is because the methodcloseRemoteStreams
that was there beforecleanupLocalStreams
handled it appropriately andcleanupLocalStreams
doesn'tby making the following changes
moveTo
method that closes the existing media connection, cleans up remote and local streams and also stops statsAnalyzer from sending any dataaddMedia
with a forced retry to do turn discovery (isMoveToInProgress
flag ensures of that in theestablishMediaConnection
method)Change Type
The following scenarios where tested
moveTo
- This ensured the Video and Audio gets cut offmoveTo
- This ensured the screenshare is properly cut off onmoveTo
I certified that
[x] I have read and followed contributing guidelines
[x] I discussed changes with code owners prior to submitting this pull request
[x] I have not skipped any automated checks
[x] All existing and new tests passed
[x] I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.