webex / webex-js-sdk

JavaScript SDK for Webex

https://webex.github.io/webex-js-sdk/

Other

167 stars 334 forks source link

fix(webex): remove plugin-presence as a dependency as it is not public #3645

Closed sreenara closed 2 weeks ago

sreenara commented 2 weeks ago

COMPLETES # NA

This pull request addresses

Issues with installation of webex 3.1.0 due to presence dependency issues.

$ npm install --save webex@3.1.0
npm ERR! code ETARGET
npm ERR! notarget No matching version found for @webex/plugin-presence@0.0.0.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

by making the following changes

Removed the @webex/plugin-presence package as a dependency.

Change Type

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Tooling change
[ ] Internal code refactor

The following scenarios where tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

[x] I have read and followed contributing guidelines
[x] I discussed changes with code owners prior to submitting this pull request
[x] I have not skipped any automated checks
[x] All existing and new tests passed
[x] I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

aws-amplify-us-east-2[bot] commented 2 weeks ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3645.d3m3l2kee0btzx.amplifyapp.com