Closed mickelr closed 2 weeks ago
This pull request is automatically being deployed by Amplify Hosting (learn more).
Access this pull request here: https://pr-3652.d3m3l2kee0btzx.amplifyapp.com
After fix, the things will be:
After fix, the things will be:
- User comes into Lobby and waits
- User joins the meeting and the LLM gets connected
- User is moved into lobby by host and disconnected LLM
- User is moved back to meeting again by host and the LLM gets connected again
Makes sense. The updateLLMConnection method disconnects and reconnects the LLM every time it is called unless the meeting.isJoined is false. Is it the case here that once host moves the user back to lobby, their meeting.isJoined()
returns false?
After fix, the things will be:
- User comes into Lobby and waits
- User joins the meeting and the LLM gets connected
- User is moved into lobby by host and disconnected LLM
- User is moved back to meeting again by host and the LLM gets connected again
Makes sense. The updateLLMConnection method disconnects and reconnects the LLM every time it is called unless the meeting.isJoined is false. Is it the case here that once host moves the user back to lobby, their
meeting.isJoined()
returns false?
That's right. The state will be "IDLE" in lobby
COMPLETES #< INSERT LINK TO ISSUE >
https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-535566
This pull request addresses
Still can receive reactions after moved into lobby
by making the following changes
Unsubcribe relay event when moved into lobby
Change Type
The following scenarios where tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
I certified that
[x] I have read and followed contributing guidelines
[ ] I discussed changes with code owners prior to submitting this pull request
[x] I have not skipped any automated checks
[x] All existing and new tests passed
[ ] I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.