webex / webex-js-sdk

JavaScript SDK for Webex

https://webex.github.io/webex-js-sdk/

Other

167 stars 334 forks source link

fix(plugin-meetings): update multistreamEnabled #3655

Closed antsukanova closed 6 days ago

antsukanova commented 2 weeks ago

COMPLETES WEBEX-389398

This pull request addresses

Currently, multistreamEnabled is not always true in the MQE, which is not correct, because we always use multistream with plugin-meetings

by making the following changes

Fix value for MQE multistreamEnabled

Change Type

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Tooling change
[ ] Internal code refactor

The following scenarios where tested

[x] automated tests for plugin-meetings
[x] SDK test meeting correctly sends MQE in automated diagnostics

I certified that

[x] I have read and followed contributing guidelines
[x] I discussed changes with code owners prior to submitting this pull request
[x] I have not skipped any automated checks
[x] All existing and new tests passed
[x] I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

aws-amplify-us-east-2[bot] commented 2 weeks ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3655.d3m3l2kee0btzx.amplifyapp.com

antsukanova commented 1 week ago

@brycetham Good point. Thanks for this comment so far. Will double check this with MQA