webex / webex-js-sdk

JavaScript SDK for Webex

https://webex.github.io/webex-js-sdk/

Other

167 stars 334 forks source link

fix(webex): remove plugin-presence from src #3657

Closed mkesavan13 closed 1 week ago

mkesavan13 commented 2 weeks ago

COMPLETES AdHoc

This pull request addresses

As part of this PR: #3645, we removed @webex/plugin-presence from the package thereby avoiding conflict while doing yarn install

This however is still not removed from the source and is causing issues when trying to import the webex package

by making the following changes

Removing @webex/plugin-presence from the src/webex.js main file also

When trying to bundle the webex package using parcel bundler:

Screenshot 2024-06-21 at 2 24 17 AM

When trying to use the SDK on a node-js app:

Screenshot 2024-06-21 at 2 22 20 AM

Change Type

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Tooling change
[ ] Internal code refactor

The following scenarios where tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

[x] I have read and followed contributing guidelines
[x] I discussed changes with code owners prior to submitting this pull request
[x] I have not skipped any automated checks
[x] All existing and new tests passed
[x] I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

aws-amplify-us-east-2[bot] commented 2 weeks ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3657.d3m3l2kee0btzx.amplifyapp.com